Add buildFromScratch
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Apr 29, 2019
kl0tl
force-pushed
the
build-from-scratch
branch
from
d0f62a2 to
0d05fe5
Compare
hdgarrood
reviewed
Apr 29, 2019
|
Looks good to me, does anyone else have any thoughts? |
|
Only question is why "scratch" and not "empty"? We have a Record.empty right? |
kl0tl
force-pushed
the
build-from-scratch
branch
from
0d05fe5 to
de4529a
Compare
|
I’m happy to rename to whatever is preferred. Please note that there’s currently no |
|
Should I rename to |
|
I don’t think we need a Record.empty when we already have |
hdgarrood
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #52.