Skip to content

Conversation

Quelklef
Copy link
Contributor

@Quelklef Quelklef commented Feb 19, 2021

Description of the change

This PR closes #143.

That issue originally was about changing the bounds checking of Data.String.CodeUntis.slice. It has since been decided that the appropriate fix is to remove bounds checking altogether and to change the type from Int -> Int -> Maybe String to Int -> Int -> String.

Additionally, there is discussion in that ticket about improving similar string-and-index operations to be more consistent with the API. Hence the WIP-ness of this PR, so that those additional changes can be added as they are pointed out.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Mar 25, 2022
@JordanMartinez
Copy link
Contributor

🏓 @thomashoneyman

@thomashoneyman thomashoneyman merged commit d9ba5d0 into purescript:master Mar 25, 2022
@Quelklef
Copy link
Contributor Author

Hey, I think this is my very first open-source contribution! Cheers all 🥂

@garyb
Copy link
Member

garyb commented Mar 25, 2022

@Quelklef Congrats! 🎉 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: allow slice (length s) (length s) on Strings

4 participants