CodeUnits length function doc references itself and is wrong #177
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -207,9 +207,6 @@ uncons s = case CU.length s of | |||
| -- | ```purescript | |||
| -- | >>> length "b 𝐀𝐀 c 𝐀" | |||
| -- | 8 | |||
| -- | -- compare to Data.String: | |||
There was a problem hiding this comment.
This should just be changed to say Data.String.CodeUnits.
michaelficarra
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In the
CodeUnitsmodule, in the documentation of the functionlengththere is a reference toData.String.lengthfunction which actually is a re-importedCodeUnits.length, so it's itself and the reference should be deleted from the doc.Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.
Checklist: