Skip to content

Conversation

@qxjit
Copy link
Contributor

@qxjit qxjit commented Jul 6, 2015

Also updated the documentation to more accurately reflect the function's
behavior.

I think the function could be given a better name to communicate its
behavior too. Since it's an exported function, I didn't rename it as
part of this fix.

Also updated the documentation to more accurately reflect the function's
behavior.

I think the function could be given a better name to communicate its
behavior too. Since it's an exported function, I didn't rename it as
part of this fix.
@garyb
Copy link
Member

garyb commented Jul 6, 2015

Hm, yeah this is a slightly strange one. It's a specialised case of span really.

@qxjit
Copy link
Contributor Author

qxjit commented Jul 6, 2015

Yeah, it's confusing enough that I actually thought dropWhile & takeWhile were doing the wrong thing until I located the original source for count.

@garyb
Copy link
Member

garyb commented Jul 6, 2015

Thanks for fixing it anyway!

garyb added a commit that referenced this pull request Jul 6, 2015
Fix missing foreign `count` function.
@garyb garyb merged commit 710382e into purescript:master Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants