Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Monoid instance #115

Merged
merged 1 commit into from
Oct 15, 2020
Merged

add Monoid instance #115

merged 1 commit into from
Oct 15, 2020

Conversation

safareli
Copy link
Contributor

No description provided.

hdgarrood
hdgarrood approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instances seem reasonable to me. Are there any other possibilities for them?

@safareli
Copy link
Contributor Author

Are there any other possibilities for them?
Not sure.

@safareli
Copy link
Contributor Author

Shell this be merged?

There are similar instances in other other monads in this repo (Reader for example) this pr just adds the instances to others for consistency. It's frustrating that some nomads have it and some don't. There might be other ways to implement this instances but I think this are most common and straight forward, I can't think of other implementations for this transformers.

@JordanMartinez JordanMartinez merged commit 9a04f8a into purescript:master Oct 15, 2020
@JordanMartinez JordanMartinez mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safareli @hdgarrood @JordanMartinez