Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stack-safe foldl #93

Merged
merged 3 commits into from
Mar 30, 2017
Merged

stack-safe foldl #93

merged 3 commits into from
Mar 30, 2017

Conversation

matthewleon
Copy link
Contributor

@matthewleon matthewleon commented Mar 27, 2017 •
edited
Loading

If this makes sense, then giving foldl' a similar treatment should as well.

@matthewleon matthewleon mentioned this pull request Mar 27, 2017
Merged
@garyb
Copy link
Member

garyb commented Mar 27, 2017

@paf31 shall we do this now? If we're going to break it again now is the time to do it again, since nothing depends on transformers yet 😉

@garyb
Copy link
Member

garyb commented Mar 27, 2017

Oh, except quickcheck, but only one thing at least.

@paf31
Copy link
Contributor

paf31 commented Mar 27, 2017

We could always add it as a non-breaking change (add foldlRec or something).

@garyb
Copy link
Member

garyb commented Mar 27, 2017

Sure, just wondered if you wanted to do it this way, and have the MonadRec by default?

@paf31
Copy link
Contributor

paf31 commented Mar 27, 2017

I think I'd prefer the non-breaking way to be honest.

@matthewleon matthewleon changed the title [BREAKING] stack-safe foldl stack-safe foldl Mar 28, 2017
@matthewleon matthewleon force-pushed the foldl-tailrec branch 2 times, most recently from 19f1af8 to 61ef639 Compare March 28, 2017 18:36
@matthewleon
Copy link
Contributor Author

This is now non-breaking. And ready for review.

@matthewleon
Copy link
Contributor Author

Rebased on master.

@paf31 paf31 merged commit e680771 into purescript:master Mar 30, 2017
@paf31
Copy link
Contributor

paf31 commented Mar 30, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewleon @garyb @paf31