Merge branch 'master' into jam/update-node-deps

src/Spago/Command/Build.purs

@@ -145,7 +145,7 @@ run opts = do
       let reportTest = pedanticPackages || (fromMaybe false $ p.package.test >>= _.pedantic_packages)
       Alternative.guard (reportSrc || reportTest)
       pure $ Tuple p { reportSrc, reportTest }
-  unless (Array.null pedanticPkgs) do
+  unless (Array.null pedanticPkgs || opts.depsOnly) do
     logInfo $ "Looking for unused and undeclared transitive dependencies..."
     eitherGraph <- Graph.runGraph globs opts.pursArgs
     graph <- either die pure eitherGraph

test-fixtures/pedantic/pedantic-instructions-initial-failure.txt

@@ -0,0 +1,24 @@
+Reading Spago workspace configuration...
+Read the package set from the registry
+
+✅ Selecting package to build: pedantic
+
+Downloading dependencies...
+Building...
+           Src   Lib   All
+Warnings     0     0     0
+Errors       0     0     0
+
+✅ Build succeeded.
+
+Looking for unused and undeclared transitive dependencies...
+
+❌ Found unused and/or undeclared transitive dependencies:
+
+Sources for package 'pedantic' import the following transitive dependencies - please add them to the project dependencies, or remove the imports:
+  effect
+    from `Main`, which imports:
+      Effect
+
+These errors can be fixed by running the below command(s):
+spago install -p pedantic effect

test-fixtures/pedantic/pedantic-instructions-installation-result.txt

@@ -0,0 +1,13 @@
+Reading Spago workspace configuration...
+Read the package set from the registry
+
+✅ Selecting package to build: pedantic
+
+Adding 1 packages to the config in spago.yaml
+Downloading dependencies...
+Building...
+           Src   Lib   All
+Warnings     0     0     0
+Errors       0     0     0
+
+✅ Build succeeded.

test/Spago/Build/Pedantic.purs

@@ -188,6 +188,34 @@ spec =
       editSpagoYaml (addPedanticFlagToSrc >>> addPedanticFlagToTest)
       spago [ "build" ] >>= shouldBeFailureErr (fixture "pedantic/check-pedantic-packages.txt")
 
+    -- A dependency on `console` will include `effect` as a transitive dependency.
+    -- So, if we don't have `effect` as a direct dependency, we'll get a pedantic error
+    -- where the fix is to install that missing package.
+    -- Following those instructions shouldn't cause an error.
+    Spec.it "following installation instructions does not fail with an unrelated pedantic error" \{ spago, fixture } -> do
+      setup spago
+        ( defaultSetupConfig
+            { installSourcePackages = [ "prelude", "console" ]
+            , installTestPackages = []
+            , main = Just
+                [ "import Prelude"
+                , ""
+                , "import Effect"
+                , "import Effect.Console as Console"
+                , ""
+                , "main :: Effect Unit"
+                , "main = Console.log \"wat\""
+                ]
+            , testMain = Nothing
+            }
+        )
+      spago [ "uninstall", "effect" ] >>= shouldBeSuccess
+      -- Get rid of "Compiling..." messages
+      spago [ "build" ] >>= shouldBeSuccess
+      editSpagoYaml (addPedanticFlagToSrc)
+      spago [ "build" ] >>= shouldBeFailureErr (fixture "pedantic/pedantic-instructions-initial-failure.txt")
+      spago [ "install", "-p", "pedantic", "effect" ] >>= shouldBeSuccessErr (fixture "pedantic/pedantic-instructions-installation-result.txt")
+
 addPedanticFlagToSrc :: Config -> Config
 addPedanticFlagToSrc config = config
   { package = config.package <#> \r -> r