Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid watching dependencies in .spago directory #430

Closed
elliotdavies opened this issue Sep 25, 2019 · 1 comment
Closed

Avoid watching dependencies in .spago directory #430

elliotdavies opened this issue Sep 25, 2019 · 1 comment
Labels
help wanted performance

Comments

@elliotdavies
Copy link
Contributor

(Split out from discussion in #420.)

When running spago build --watch we monitor changes to local (i.e. monorepo) dependencies, but we also watch for changes in the .spago directory. I'm not sure if there are any performance implications, but it's unintended behaviour and has potential to cause weird edge cases (as in #420) so we ought to stop doing it 😀
@elliotdavies elliotdavies mentioned this issue Sep 25, 2019
Merged
3 tasks
Benjmhart added a commit to Benjmhart/spago that referenced this issue Oct 7, 2019
@Benjmhart
add purescript#430 to changelog
db9198f
@Benjmhart Benjmhart mentioned this issue Oct 7, 2019
Merged
3 tasks
@f-f
Copy link
Member

f-f commented Oct 13, 2019

Fixed in #446

@f-f f-f closed this as completed Oct 13, 2019
mergify bot pushed a commit that referenced this issue Oct 26, 2019
@Benjmhart @mergify
Add a 'Getting Started With Parcel' to docs (#461)
8429904 
* filter out files in .spago folder from watch list

* add #430 to changelog

* Update src/Spago/Build.hs

Co-Authored-By: Jan Hrcek <honza.hrk@gmail.com>

* fix build by importing split directories

* added step-by-step guide to setting up a spago + parcel project to documentation

* cleanup

* changelog
Benjmhart added a commit to Benjmhart/spago that referenced this issue Oct 27, 2019
@Benjmhart
Add a 'Getting Started With Parcel' to docs (purescript#461)
1a62e97 
* filter out files in .spago folder from watch list

* add purescript#430 to changelog

* Update src/Spago/Build.hs

Co-Authored-By: Jan Hrcek <honza.hrk@gmail.com>

* fix build by importing split directories

* added step-by-step guide to setting up a spago + parcel project to documentation

* cleanup

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliotdavies @f-f