Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation via Yarn - issue #157 #166

Merged
merged 4 commits into from
Mar 30, 2019

Conversation

Dretch
Copy link
Contributor

@Dretch Dretch commented Mar 30, 2019

I also removed the main key in package.json because it seemed to be bogus (there is no index.js), and renamed spago to spago.exe in files, to match the actual file name.

PR checklist:

  • Added a test for the contribution (if applicable)
  • Updated the version number in package.yaml according to SemVer (0.x.y.z, x changes on breaking changes, y on additions, z on patches)
  • Added some example of the new feature to the README

(I didn't do any of the PR checklist stuff - do I need to for this change?)

npm/package.json Outdated Show resolved Hide resolved
npm/spago.exe Outdated Show resolved Hide resolved
@f-f
Copy link
Member

f-f commented Mar 30, 2019

@Dretch the only applicable item from the checklist is bumping the version to 0.7.5.0 in package.yaml, so I can cut a release with the fix

f-f and others added 3 commits March 30, 2019 14:03
@f-f
Copy link
Member

f-f commented Mar 30, 2019

Thanks @Dretch!

@f-f f-f merged commit 3117750 into purescript:master Mar 30, 2019
elliotdavies pushed a commit to elliotdavies/spago that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants