Report all missing packages #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahlberg
commented
Jun 14, 2019
eahlberg
commented
Jun 14, 2019
|
@f-f thanks for the intro and help earlier today! If you (or anyone else) has feedback about the code in the PR, it's really appreciated! Regarding the correctness, I'm still confused why the tests fail when it works locally by running |
|
Apparently, the tests pass on the CI 🤔 |
eahlberg
force-pushed
the
report-all-missing-packages
branch
from
692a5a0
to
33d5baa
Compare
|
Alright, so I got a bit further with this:
|
eahlberg
force-pushed
the
report-all-missing-packages
branch
from
06e2193
to
8ac1573
Compare
eahlberg
force-pushed
the
report-all-missing-packages
branch
from
8ac1573
to
b4579de
Compare
elliotdavies
pushed a commit
to elliotdavies/spago
that referenced
this pull request
Jul 1, 2019
If there are multiple dependencies which do not exist in the package set instead of just reporting the first missing package, all missing packages will be reported. In the same manner, all circular dependency errors will be reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
If there are multiple dependencies which do not exist in the package set, instead of just reporting the first missing package, all missing packages will be reported which fixes #223. In the same manner, all circular dependency errors will be reported.
Checklist:
Added some example of the new feature to theREADMEAdded a test for the contribution (if applicable)