-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for global REPL #280
Conversation
@f-f I decided to take a look at this and I tried to implement it according to #168 (comment). However, I’m a bit unsure of a couple of things (in addition to the comment above):
|
@eahlberg looks good so far! I added some minor comments, and to answer your other points:
|
I just noticed that in addition to the install flags we'll also need to add the |
@f-f thanks for the feedback! 🙇♂️ I think I’ve addressed all of it and I also left a couple of questions above, so feel free to take a look when time permits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion but otherwise looks great! 👏
I added you as collaborator so you can merge when you're ready 🙂
Co-Authored-By: Fabrizio Ferrai <fabrizio.ferrai@gmail.com>
@f-f cool, thanks! |
* Support global repl * Update CHANGELOG * Refactor * Change flag name and use SomeException * Remove unused import Co-Authored-By: Fabrizio Ferrai <fabrizio.ferrai@gmail.com>
Description of the change
Adds support for starting a REPL within a folder which has not been setup as a spago project. Fixes #168.
Checklist:
Added some example of the new feature to theREADME
Added a test for the contribution (if applicable)