Remove mkPackage Dhall function and switch to package-sets releases #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…s is to prevent Travis failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to purescript/package-sets#399
Changes:
mkPackagefrom template (fix Remove mkPackage from template #320)packages.dhallfrom releases (fix Template should use release package-sets #319)TODO:
mkPackagefrom README and testsWait for Import local packagesupdate: we don't need to wait, but we'll need to be careful in there so that we don't miss references toas Location#301 to be mergedmkPackageCuratorto the new format ofpackage-setsAddEDIT: skipping this, so many corner casesdhall lintinvocation to remove unused bindings inpackages.dhallAdd warning to removeEDIT: crawling the AST is lots of work, and just grepping has false positives. Giving up is fine, because the schema is backwards compatible.mkPackageif we detect it somewhere