Improved README for additions #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-f
reviewed
Aug 5, 2019
| @@ -466,9 +466,9 @@ let additions = | |||
| , "effect" | |||
| ] | |||
| , repo = | |||
| "https://github.com/Unisay/purescript-facebook.git" | |||
| "https://github.com/Unisay/purescript-facebook.git" -- must be https not ssh | |||
There was a problem hiding this comment.
Suggested change
| "https://github.com/Unisay/purescript-facebook.git" -- must be https not ssh | |
| "https://github.com/Unisay/purescript-facebook.git" |
I'd like to skip this comment because there's a pretty comprehensive explanation to convert the URL in the error message you get if you try to use the ssh url, as detailed in #348 (comment).
E.g. following the instructions there you could convert this URL to ssh as ssh://git@github.com/Unisay/purescript-facebook.git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #347