Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look up remote imports dynamically when doing frozen check #402

Merged
merged 11 commits into from
Sep 16, 2019

Conversation

elliotdavies
Copy link
Contributor

@elliotdavies elliotdavies commented Sep 6, 2019

Description of the change

To fix #349 we no longer look for packages.dhall directly when checking that the remote imports are frozen. Instead we look at spago.dhall and check all remote imports in its dependency graph.

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

@elliotdavies
Copy link
Contributor Author

elliotdavies commented Sep 6, 2019

@f-f Submitting this as a draft to check I'm working along the same lines as you were thinking. If so I'll do the tests, changelog, etc.

The _stack part of the Status didn't seem to contain much, but I was able to retrieve what we need from _graph instead.

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elliotdavies yes this is exactly what I was looking for! I left some minor suggestions but it's almost ready to go 🙂

package.yaml Outdated Show resolved Hide resolved
src/Spago/Dhall.hs Outdated Show resolved Hide resolved
src/Spago/Dhall.hs Show resolved Hide resolved
src/Spago/PackageSet.hs Outdated Show resolved Hide resolved
@elliotdavies
Copy link
Contributor Author

@f-f Ace - I'll try to get this done today in the hopes of making the v10 release 😄

@elliotdavies elliotdavies marked this pull request as ready for review September 9, 2019 13:37
@elliotdavies
Copy link
Contributor Author

@f-f Ready to re-review I think!

package.yaml Outdated Show resolved Hide resolved
src/Spago/Config.hs Outdated Show resolved Hide resolved
src/Spago/PackageSet.hs Outdated Show resolved Hide resolved
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot @elliotdavies! 👏

@elliotdavies
Copy link
Contributor Author

@f-f Awesome! One other thing - at the moment we call freeze once per local import, so in a large monorepo setup you might see Generating new hashes... quite a few times. It's not a huge issue but the UX is a bit odd. Is it overkill to add a shouldEcho flag to freeze, or something?

@f-f
Copy link
Member

f-f commented Sep 16, 2019

@elliotdavies great point, and I'm not sure how to solve it. We could try moving the print around (e.g. in ensureFrozen instead of freeze), but let's take that in another PR so we can see the changes separately from this, which I'll merge now. Thank you! 🙂

@f-f f-f merged commit 61746af into purescript:master Sep 16, 2019
@elliotdavies elliotdavies deleted the fix-frozen-check branch September 16, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locate packages.dhall based on spago.dhall
2 participants