Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spago verify-set fail if there are duplicate module names. #438

Merged
merged 4 commits into from
Oct 5, 2019

Conversation

Dretch
Copy link
Contributor

@Dretch Dretch commented Oct 3, 2019

This is needed for https://github.com/purescript/package-sets/issues/490

Note that spago verify <package> does not do the check, only spago verify-set does. This is because the check requires downloading and compiling all packages, which would make spago verify <package> almost as slow as spago verify-set.

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

@Dretch Dretch requested a review from f-f October 3, 2019 13:17
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dretch looks great to me! 👏

@justinwoo could you take a look?

@justinwoo
Copy link
Contributor

looks like it does what is desired. i don't think this is necessarily what someone who manages their own package set will want to do, but in those cases, someone might use dhall-to-json <<< packages.dhall | jq 'keys[]' -r | xargs -I% spago verify % or something as needed.

@f-f
Copy link
Member

f-f commented Oct 4, 2019

@justinwoo great point. We might want to add a --skip-duplicated-module-check flag then? (it's not an actual suggestion for the flag name, but just to give the idea)

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Dretch Dretch merged commit c00b35b into master Oct 5, 2019
@Dretch Dretch deleted the verify-set-check-module-conflicts branch October 5, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants