Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve confusing warning when installing already added deps #439

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Improve confusing warning when installing already added deps #439

merged 2 commits into from
Oct 4, 2019

Conversation

jhrcek
Copy link
Contributor

@jhrcek jhrcek commented Oct 4, 2019 •
edited
Loading

Description of the change

Fix for #436

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

jhrcek
jhrcek commented Oct 4, 2019
View reviewed changes
test/Utils.hs Show resolved Hide resolved
@jhrcek
Copy link
Contributor Author

jhrcek commented Oct 4, 2019 •
edited
Loading

Both travis and appveyor build failed due to github rate limit. Not sure if I should rerun the tests (rate limit will probably be still in place at the moment)..

f-f
f-f approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this! 👏

CI should be fixed once #441 gets merged and we rebase on it

test/Utils.hs Show resolved Hide resolved
templates/spago.dhall Show resolved Hide resolved
src/Spago/Config.hs Show resolved Hide resolved
@f-f f-f changed the title Improve confusing warning when installing aleady added deps Improve confusing warning when installing already added deps Oct 4, 2019
@f-f f-f merged commit 1031d5d into purescript:master Oct 4, 2019
@jhrcek jhrcek deleted the fixConfusingWarning branch October 4, 2019 12:21
@f-f f-f mentioned this pull request Oct 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-f f-f f-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhrcek @f-f