Avoid warnings with empty list of things #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix for #447
Force user to provide nonempty list of things to warn about to avoid printing nonsensical warnings.
While I was at it I also applied the same strategy to another warning-creating function which was expecting list of things.
Checklist:
README
probably not worth adding to the changelog as this bug was introduced in another PR which is in the changelog. Also didn't add a test for this, as this is the kind of fix based on "making impossible states impossible" strategy / using types to prevent errors.