Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse absolute globs to watch relative paths in source configs #556

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

rnons
Copy link
Contributor

@rnons rnons commented Jan 30, 2020

Description of the change

I often have a setup like this

├── examples
└── src

in examples/spago.dhall, I have

, sources =
    [ "src/**/*.purs", "../src/**/*.purs" ]

The problem is file changes in the root src folder won't trigger rebuild, because /home/rnons/pkg/src/a/b.purs doesn't match /home/rnons/pkg/examples/../src/**/*.purs.

This PR collapses /home/rnons/pkg/examples/../src/**/*.purs to /home/rnons/pkg/src/**/*.purs, so that watching works as expected.

Checklist:

  • Added the change to the "Unreleased" section of the changelog

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🙂

@f-f f-f merged commit d136084 into purescript:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants