Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spago.cabal to get version #788

Merged
merged 2 commits into from
May 3, 2021
Merged

Use spago.cabal to get version #788

merged 2 commits into from
May 3, 2021

Conversation

cofad
Copy link
Contributor

@cofad cofad commented May 3, 2021

Description of the change

Use spago.cabal in the get-version script. Previously package.yaml was used; however, that file was removed.

closes #787

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

f-f
f-f approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@f-f f-f merged commit 11369c7 into purescript:master May 3, 2021
@cofad cofad deleted the use-spago.cabal-to-get-version branch May 3, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-f f-f f-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release script not able to get version number
2 participants
@cofad @f-f