Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Websocket hijacking vulnerability #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wwwarrior
Copy link

WebSockets don't follow the Same-Origin Policy. This means that if the application relies on cookies (or Basic authentication) to perform authentication/authorization, a malicious website can get a victim to access this application via a WebSocket and potentially access/modify sensitive data as this user.

I created a Proof of Concept (malicious html-page) allowing read logs through this vulnerability.

More information about the vulnerability you can find here:
https://portswigger.net/web-security/websockets/cross-site-websocket-hijacking

To prevent this issue, the Origin header check was added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant