Fix Websocket hijacking vulnerability #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSockets don't follow the Same-Origin Policy. This means that if the application relies on cookies (or Basic authentication) to perform authentication/authorization, a malicious website can get a victim to access this application via a WebSocket and potentially access/modify sensitive data as this user.
I created a Proof of Concept (malicious html-page) allowing read logs through this vulnerability.
More information about the vulnerability you can find here:
https://portswigger.net/web-security/websockets/cross-site-websocket-hijacking
To prevent this issue, the Origin header check was added.