Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: trying to fix versioning #4

Merged
merged 3 commits into from
Apr 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: fixing build
kieronlanning committed Apr 9, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 038f015668e41553ae46b744ef33ad05e12dbbe6
31 changes: 2 additions & 29 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@ on:
env:
POWERSHELL_TELEMETRY_OPTOUT: 1
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_NOLOGO: true

SolutionPath: ./Purview.Telemetry.SourceGenerator.sln
@@ -38,8 +39,6 @@ jobs:
- uses: paulhatch/semantic-version@v5.4.0
name: version
id: version
with:
debug: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@@ -48,7 +47,7 @@ jobs:
uses: actions/setup-dotnet@v4

# Create the NuGet package in the folder from the environment variable NuGetDirectory
- run: dotnet pack ${{ env.SolutionPath }} --configuration ${{ env.BuildConfigutation }} --output ${{ env.NuGetDirectory }} --property:Version=${{ steps.version.output.version }} --include-symbols
- run: dotnet pack ${{ env.SolutionPath }} --configuration ${{ env.BuildConfigutation }} --output ${{ env.NuGetDirectory }} --property:Version=${{ steps.version.outputs.version }} --include-symbols

# Publish the NuGet package as an artifact, so they can be used in the following jobs
- uses: actions/upload-artifact@v4
@@ -58,31 +57,6 @@ jobs:
retention-days: 7
path: ${{ env.NuGetDirectory }}/*.nupkg

# validate_nuget:
# runs-on: ubuntu-latest
# needs: [ create_nuget ]
# steps:
# # Install the .NET SDK indicated in the global.json file
# - name: Setup .NET
# uses: actions/setup-dotnet@v4

# # Download the NuGet package created in the previous job
# - uses: actions/download-artifact@v4
# with:
# name: nuget
# path: ${{ env.NuGetDirectory }}

# - name: Install nuget validator
# run: dotnet tool update Meziantou.Framework.NuGetPackageValidation.Tool --global

# # Validate metadata and content of the NuGet package
# # https://www.nuget.org/packages/Meziantou.Framework.NuGetPackageValidation.Tool#readme-body-tab
# # If some rules are not applicable, you can disable them
# # using the --excluded-rules or --excluded-rule-ids option
# - name: Validate package
# working-directory: ${{ env.NuGetDirectory }}
# run: meziantou.validate-nuget-package (Get-ChildItem "*.nupkg")

run_test:
runs-on: ubuntu-latest
steps:
@@ -98,7 +72,6 @@ jobs:
# You can update this logic if you want to manage releases differently
if: github.event_name == 'release'
runs-on: ubuntu-latest
# needs: [ validate_nuget, run_test ]
needs: [ run_test ]
steps:
# Download the NuGet package created in the previous job