Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): migrate to lh v11 #277

Merged
merged 70 commits into from
Aug 26, 2024
Merged

feat(cli): migrate to lh v11 #277

merged 70 commits into from
Aug 26, 2024

Conversation

ChristopherPHolder
Copy link
Collaborator

@ChristopherPHolder ChristopherPHolder commented Apr 22, 2024

TL;DR

Migration for to ESM and Lighthouse v11

Description

This MR does all the necessary change to upgrade lighthouse from v9 to v11

It migrated the code base to ESM, and type module.

It migrated to lighthouse v11 which removes the use of fraggle-rock.

It migrated to prettier v3 which allows the use of satifies and makes the functions async.

Note

Because of the module resolution we need to add the .js at the end of imports

We could use a bundler or a compiler but this is a valid approach:

https://www.totaltypescript.com/relative-import-paths-need-explicit-file-extensions-in-ecmascript-imports
https://youtu.be/8ORIzvgNWhU?si=hNpqrsM65n5o0rP5

Now the user-flow require being in esm with a sufix of .mts and stepName has been renamed to name in flow actions like navigate timespan and snapshot

BREAKING CHANGES: lighthouse api changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

❗❗❗ report generated by this PR ❗❗❗

Copy link

☕ Order Coffee ☕

Date/Time: 2024-08-26 14:19

Step Name Gather Mode Performance Accessibility Best Practices Seo Pwa
🧭 Navigate to coffee cart navigation 97 97 100 85 30
☕ Select coffee timespan 11/11 - 7/7 - -
✔ Coffee selected snapshot Ø 3/3 15/16 5/5 7/9 -
🛒 Checkout order timespan 13/13 - 7/7 - -
🧾 Order checked out snapshot Ø 3/3 17/18 5/5 7/9 -
💌 Submit order timespan 13/13 - 7/7 - -
📧 Order submitted snapshot Ø 3/3 15/16 5/5 7/9 -
🧭 Navigate to github navigation 98 96 100 85 30

@ChristopherPHolder ChristopherPHolder merged commit ae3f82e into main Aug 26, 2024
3 checks passed
@ChristopherPHolder ChristopherPHolder deleted the chore/migrate/lh-v11 branch August 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant