-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): migrate to lh v11 #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChristopherPHolder
force-pushed
the
chore/migrate/lh-v11
branch
from
April 26, 2024 12:34
c1c1661
to
b87b771
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❗❗❗ report generated by this PR ❗❗❗ |
☕ Order Coffee ☕Date/Time: 2024-08-26 14:19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Migration for to ESM and Lighthouse v11
Description
This MR does all the necessary change to upgrade lighthouse from v9 to v11
It migrated the code base to ESM, and type module.
It migrated to lighthouse v11 which removes the use of fraggle-rock.
It migrated to prettier v3 which allows the use of satifies and makes the functions async.
Note
Because of the module resolution we need to add the .js at the end of imports
We could use a bundler or a compiler but this is a valid approach:
https://www.totaltypescript.com/relative-import-paths-need-explicit-file-extensions-in-ecmascript-imports
https://youtu.be/8ORIzvgNWhU?si=hNpqrsM65n5o0rP5
Now the user-flow require being in esm with a sufix of .mts and stepName has been renamed to name in flow actions like navigate timespan and snapshot
BREAKING CHANGES: lighthouse api changes