Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface with new methods and remove duplicated docs #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpi
Copy link

@dpi dpi commented Oct 21, 2023

Description

  • interface updates: new methods, adds a variety of methods to the interface that have been added since the interface was introduced.
  • Removed documentation from Pusher class. Documentation is implied when inherited from interface.

For the most part, this PR is just a bunch of move/copy-paste.

CHANGELOG

  • [CHANGED] Added newly introduced methods to Pusher interface.

Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major breaking change.

@dpi
Copy link
Author

dpi commented Oct 21, 2023

Perhaps, do the maintainers of this project consider the missing methods from the interface intentional?

Should implementors of the interface be required to add these methods?

Other ideas:

  • Wait for a new major
  • Add new methods to interface as @method instead, at least in the interim.
  • I think the doc removals from Pusher class could happen immediately.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

@stale stale bot added the wontfix label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants