Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alow sodium_compat v1 or v2 #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Alow sodium_compat v1 or v2 #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"ext-json": "*",
"guzzlehttp/guzzle": "^7.2",
"psr/log": "^1.0|^2.0|^3.0",
"paragonie/sodium_compat": "^1.6"
"paragonie/sodium_compat": "^1|^2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you keep the existing lowest bound instead of reverting it to 1.0 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point.

Alternatively, ^1.21|^2 might be more appropriate, given the long list of bug fixes since 1.6.0.

},
"require-dev": {
"phpunit/phpunit": "^9.3",
Expand Down