Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong uri for RestApi requests in Pusher.php #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cekaon
Copy link

@cekaon cekaon commented May 24, 2024

Description

The URL for pusher requests is badly composed, when URL path is defined in config. The 'base_uri' for Guzzle request is concatenated with config path and therefore, it does not work correctly, becouse 'base_uri' is only for host address. Also, in custom websocket server, there is a need to override the socket id validation to the custom rules, so please set it as protected.

CHANGELOG

  • [FIXED] Composion of $settings['base_path']
  • [FIXED] Return of channels_url_prefix()
  • [CHANGED] Change from private to protected in validate_socket_id()

The uri is badly composed, when url path is defined in config. Base uri for Guzzle is concatenated with config path and therefore, it does not work. Also, in custom websocket server, I need to override the socket id validation to the custom rule, so please set it as protected.
@cekaon cekaon changed the title Update Pusher.php Bad uri for RestApi requests in Pusher.php May 24, 2024
@cekaon cekaon changed the title Bad uri for RestApi requests in Pusher.php Wrong uri for RestApi requests in Pusher.php May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant