Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error via SubscriptionListener when presence events are malformed #290

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

jonathanlloyd
Copy link
Contributor

@jonathanlloyd jonathanlloyd commented Nov 5, 2020

This PR resolves: #286

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #290 (8816840) into master (93c25bc) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
- Coverage     76.08%   76.03%   -0.05%     
- Complexity      284      285       +1     
============================================
  Files            31       32       +1     
  Lines          1802     1807       +5     
  Branches        137      139       +2     
============================================
+ Hits           1371     1374       +3     
- Misses          375      376       +1     
- Partials         56       57       +1     
Impacted Files Coverage Δ Complexity Δ
...sher/client/channel/SubscriptionEventListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...usher/client/channel/impl/PresenceChannelImpl.java 78.20% <80.00%> (-0.18%) 20.00 <3.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c25bc...8816840. Read the comment docs.

@danielrbrowne danielrbrowne marked this pull request as ready for review March 11, 2021 15:04
@ccaseypusher ccaseypusher requested a review from elverkilde March 16, 2021 10:59
@danielrbrowne danielrbrowne merged commit 49ce2d9 into master Mar 17, 2021
@danielrbrowne danielrbrowne deleted the add-error-when-presence-data-missing branch March 17, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in PresenceChannelImpl.java causing a crash
4 participants