-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OpenSSL 3 #2
Conversation
This is the same PR sent to the original and adjusted for this fork See zaru/webpush#106 Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Thanks for working on this!!
|
Our image too is based on debian stable, but without this booting the app in development is broken for every dev using Arch, Ubuntu, Fedora, or any up to date distro, which is too much friction for us. No worries tho, we will fork this and use our fork then. |
Yes, sure, you can use a fork in the meantime. I will certainly merge this pull request (or equivalent) as soon as Debian stable uses OpenSSL v3 (i.e. when Bookworm becomes stable). Maybe I can merge even before that, but let me think about that. Please feel free to suggest any other fixes / improvements to this library and I will be happy to merge them. |
Related: ruby/openssl#369 (comment) Basically the future versions of the openssl gem will provide a method for creating the curve directly from the keys, without ASN1. The new method is in C, so probably performance are better. In any case, at the moment, the correct solution is the one presented in this pull request. |
@xfalcox I am planning to release a v3 of this gem with compatibility with OpenSSL v3. I would like to merge this pull request, but it should not include the commit for Ruby 2.7, because it is not related to this issue.
|
I have released v3 of this gem, which is compatible with both OpenSSL 1.1 and OpenSSL 3 🎉 I have also added @xfalcox and @ClearlyClaire to co-authors of the commit. Thanks for the contributions. |
Cool, moved back into your fork in discourse/discourse#19849 |
This is the same PR sent to the original and adjusted for this fork
See zaru/webpush#106
Co-authored-by: Claire claire.github-309c@sitedethib.com