Skip to content

Commit

Permalink
reduce volatility in embed percy snapshots (getredash#3672)
Browse files Browse the repository at this point in the history
  • Loading branch information
Omer Lachish authored and harveyrendell committed Nov 14, 2019
1 parent b340a3e commit 5374671
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions client/cypress/integration/embed/share_embed_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('Embedded Queries', () => {
it('are shared with safe parameters', () => {
cy.getByTestId('QueryEditor')
.get('.ace_text-input')
.type('SELECT * FROM organizations WHERE id=\'{{}{{}id}}\'{esc}', { force: true });
.type('SELECT name, slug FROM organizations WHERE id=\'{{}{{}id}}\'{esc}', { force: true });

cy.getByTestId('TextParamInput').type('1');
cy.clickThrough(`
Expand All @@ -31,7 +31,7 @@ describe('Embedded Queries', () => {
it('cannot be shared with unsafe parameters', () => {
cy.getByTestId('QueryEditor')
.get('.ace_text-input')
.type('SELECT * FROM organizations WHERE name=\'{{}{{}name}}\'{esc}', { force: true });
.type('SELECT name, slug FROM organizations WHERE name=\'{{}{{}name}}\'{esc}', { force: true });

cy.getByTestId('TextParamInput').type('Redash');
cy.clickThrough(`
Expand Down

0 comments on commit 5374671

Please sign in to comment.