Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mask computation and simplify method #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve mask computation and simplify method #24

wants to merge 1 commit into from

Conversation

etrepum
Copy link

@etrepum etrepum commented Aug 12, 2021

mask >= alphabet_len - 1 must be True, but the difference should be minimized. For powers of 2 we expect mask == alphabet_len - 1 .

@etrepum
Improve mask computation and simplify method
040341e 
`mask >= alphabet_len - 1` must be True, but the difference
should be minimized. For powers of 2 we expect
`mask == alphabet_len - 1 `.
@DairAidarkhanov
Copy link
Contributor

Very cool! Hopefully, the package owner will push the changes.

@oliverlambson oliverlambson mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etrepum @DairAidarkhanov