Cleanup/separate class for swtpm2 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it was just a think-o mistake. After the timeout expires, then kill the process with the given signal. After 5 more seconds if the thread is still alive then kill it with SIGKILL.
If data was None, the 'indent' wouldn't work correctly.
This isolates the swtpm interaction into an swtpm2 class. It makes it much easier to work with.
hallyn
approved these changes
Jul 28, 2023
Serge didn't like the "join"s that I had. Instead, use a .format style template.
This just adds a common do_communicate which will handle the timeout/send-signal/delay/kill function that was in both subp and the swtpm wrapper.
Allow the caller of the swtpm to call 'stop' with a specific signal.
This way you can see time between events.
smoser
force-pushed
the
cleanup/separate-class-for-swtpm2
branch
from
c99225e
to
caa24ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate the control of tpm2 into a class.
might be nice to do the same to qemu.