Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete requirements.txt; related CI & test changes #149

Merged
merged 7 commits into from
Aug 15, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Aug 2, 2022

Description

There are two main reasons we might want to have a requirements.txt:

  • As an environment spec for users. But pvanalytics is a library, not an application, so we prefer dependency ranges in setup.py over dependency versions in a requirements file.
  • As an environment spec for testing, if you need specific versions beyond what's specified in setup.py. We don't (currently) need that, so there's no need for a requirements.txt file either. The exception is requirements-min.txt, which of course is not equivalent to setup.py.

This PR deletes requirements.txt so there's one less place to keep track of dependencies. This required a bit of reworking of the CI configuration, which then uncovered some minor oversights in the tests.

Checklist

@kandersolar kandersolar added the ci Continuous Integration label Aug 2, 2022
@kandersolar kandersolar added this to the v0.1.2 milestone Aug 2, 2022
@kandersolar kandersolar marked this pull request as ready for review August 2, 2022 17:47
@kandersolar kandersolar mentioned this pull request Aug 2, 2022
8 tasks
@kperrynrel kperrynrel requested review from kperrynrel and removed request for kperrynrel August 15, 2022 16:27
@kandersolar kandersolar merged commit 76a8ccc into pvlib:master Aug 15, 2022
@kandersolar kandersolar deleted the ci-updates branch August 15, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements in setup.py are redundant, and partially inconsistent, with requirements.txt
2 participants