Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_daytime.py: work around pvlib v0.11.1 sunrise/set issue #213

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

kandersolar
Copy link
Member

  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

test_daytime.py::test_consistent_modeled_midday_series is failing with pvlib 0.11.1 due to pvlib/pvlib-python#2238

The pvlib issue affected this pvanalytics test through coincidental implementation detail. This PR works around the change so that the pvanalytics test works with both the previous and the current pvlib behavior.

@kandersolar kandersolar added the tests Something is wrong with the test suite label Oct 4, 2024
@kandersolar kandersolar added this to the v0.2.1 milestone Oct 4, 2024
@cwhanse cwhanse merged commit 0b40e0c into pvlib:main Oct 4, 2024
36 checks passed
@kandersolar kandersolar deleted the test_daytime_pvlib0111 branch October 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Something is wrong with the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants