-
Notifications
You must be signed in to change notification settings - Fork 1.1k
doc: add variables #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sure, that makes sense now that the names have stabilized. Can you make a pr? |
sure. I suggest to use Do you agree? |
Why do you prefer this to the standard sphinx table format? I think the sphinx format is easier to read in the doc source code. |
Was fastest to implement. |
Ok, well I am confused about the status since you closed your PR and deleted your branch. Please provide a link to rtd's rendering your branch when you (re)open your PR. |
I am definitly not a git pro. But I tried to pack my 3 commits together. So maybe github closed it through the commands. |
Shall we also compare the parameter names with IEC 61724? |
You'll have to be more specific for me to understand what you're really proposing. |
I'm ok with adding a symbol column, but I don't think we should tie it to the IEC document. I would default to the PVPMC symbols. |
sure, the other one is just for reference. But it's good in the case one performs performance evaluation with usually bases on the IEC or the contractual formulas. an units are helpful, too. |
My preference is for a simple table that is focused on the pvlib-python standards. A handful of links to documents such as the IEC's and PVPMC website could be useful below the table. |
mmh. |
I don't know what that means. |
Let's start with your proposal. |
Comment #102 (comment) implemented in 2 items I find strange:
I tested these Looking forward to your feedback to be able to close this issue ;-) |
Clsong since the PR #103 was merged. |
Hello,
anything against adding
https://github.com/pvlib/pvlib-python/wiki/Variables-and-style-rules
to the sphinx docs?
this way, I have them with me also when offline.
The text was updated successfully, but these errors were encountered: