Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSRDB Surface Albedo values are changed for 2019 files #1091

Closed
cwhanse opened this issue Nov 20, 2020 · 3 comments · Fixed by #1107
Closed

NSRDB Surface Albedo values are changed for 2019 files #1091

cwhanse opened this issue Nov 20, 2020 · 3 comments · Fixed by #1107
Milestone

Comments

@cwhanse
Copy link
Member

cwhanse commented Nov 20, 2020

The function iotools.get_psm3 is tested by retrieving 5-min data for the year 2019. The values on 2019-01-01 are compared to a copy of data from the NSRDB stored in pvlib\data\test_psm3_2019_5min.csv.

The surface albedo values being returned by NSRDB now are different than in the stored copy. This appears to be the only difference between NSRDB-served values and the stored file.

See the failed test for #1085 where the expected surface albedo is 0.87, the returned values vary but are around 0.45.

I suggest we comment out checking the albedo in the psm3 test for now.

@kandersolar
Copy link
Member

Thanks @cwhanse, and sorry this sort of thing keeps popping up. I emailed the NSRDB team about the data change and will report back what I hear.

@kandersolar
Copy link
Member

Partial update to give context to the XPASS failure in #1101 -- there was a data loading issue to the NSRDB API backend storage which is in the process of being corrected. Not yet sure if the data we have on file for the test is correct or not.

@kandersolar
Copy link
Member

The NSRDB team tells me that the correction is now complete. I'll open a PR to undo the xfail marker shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants