Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify weather includes 'dhi' in ModelChain.prepare_inputs() #1093

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Verify weather includes 'dhi' in ModelChain.prepare_inputs() #1093

merged 3 commits into from
Nov 23, 2020

Conversation

wfvining
Copy link
Contributor

@wfvining wfvining commented Nov 20, 2020 •
edited
Loading

  • Closes ModelChain.prepare_inputs can succeed with missing dhi #1092
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@wholmgren wholmgren added this to the 0.8.1 milestone Nov 21, 2020
@wholmgren wholmgren added the bug label Nov 21, 2020
@wfvining
Copy link
Contributor Author

wfvining commented Nov 23, 2020 •
edited
Loading

I think this is ready for review, but I'm not sure what that test failure is about. It is from test_get_psm3_5min, which should be completely unaffected by this PR (doesn't look like the test interacts with ModelChain at all).

@cwhanse
Copy link
Member

cwhanse commented Nov 23, 2020

Test failure is due to #1091

wholmgren
wholmgren approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wfvining. I suggest we go ahead and merge.

@wfvining
Copy link
Contributor Author

Thanks @cwhanse. I suspected it might be something like that.

@wholmgren wholmgren merged commit 1024194 into pvlib:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wholmgren wholmgren wholmgren approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.

ModelChain.prepare_inputs can succeed with missing dhi
3 participants
@wfvining @cwhanse @wholmgren