Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module_height documentation #1263

Closed
wholmgren opened this issue Jul 27, 2021 · 2 comments
Closed

module_height documentation #1263

wholmgren opened this issue Jul 27, 2021 · 2 comments

Comments

@wholmgren
Copy link
Member

wholmgren commented Jul 27, 2021

Here, I don't understand module_height; does it not change with tracker rotation? Maybe axis_height and an internal calculation would produce module_height as an attribute, not an input parameter. In FixedMount, module_height is merely awkward, as the measurement that seems more likely to be at hand is the height of the bottom of the module above ground.

I'm OK merging this as is and improving in later PRs.

Originally posted by @cwhanse in #1176 (comment)

@Lakshyadevelops
Copy link
Contributor

Lakshyadevelops commented Mar 19, 2023

aren't panels connected on their mid of face. Which would then say height of module at mid remain constant if any rotation would occur rather than the bottom of it.
image
I would recommend to close this issue.

Totally noob so correct me if I am wrong. @cwhanse

@cwhanse
Copy link
Member

cwhanse commented Nov 11, 2024

Closing because 1) the current documentation is clear and unambiguous and 2) lack of comment on the definition of this term since it was added.

@cwhanse cwhanse closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants