-
Notifications
You must be signed in to change notification settings - Fork 1.1k
clearsky.py requires scipy.io #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Recent matlab files should be hdf5 based (see this question on SO). So maybe we could simply update this file and read it with |
Looks like it's matlab 5.
I checked the PVLIB 1.2 release and it's the same. I think that the ideal situation would be for both the matlab and python projects to use the same |
Yes, I think the best would be for us to lead in translating this into a more portable file format, best case would be a .csv that can then be read with standard techniques (as this is just a 2D array). Any takers? In the near term, @wholmgren , could you add scipy.io to the setup.py to make sure we're internally consistent? |
Yes, but I would prefer to go with something like try:
import scipy.io
except ImportError:
raise(ImportError, 'You must install scipy to automatically load the Linke Turbidities') right before line 137. |
Sounds good to me |
I close this for 0.1 in favor of #36 |
Scipy either needs to be added to the setup.py file or we need to wrap the scipy statement with try/except and then throw a warning about reduced usability.
I would lean towards the latter as scipy installation is much more difficult than numpy and pandas. Best would be to remove the scipy.io dependency entirely.
The text was updated successfully, but these errors were encountered: