Skip to content

pandas 0.18.0 incompatibility in tests #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Mar 12, 2016 · 1 comment · Fixed by #131
Closed

pandas 0.18.0 incompatibility in tests #130

wholmgren opened this issue Mar 12, 2016 · 1 comment · Fixed by #131
Labels
Milestone

Comments

@wholmgren
Copy link
Member

The pvlib tests pass using the new pandas 0.18.0, with one exception: test_calcparams_desoto. The data is still being calculated correctly, but the np.round function used in the test now chokes on the Series object. The helpful pydata people are going to fix this upstream for pandas 0.18.1, but I'll hack around this in the meantime. For more, see pandas-dev/pandas#12600.

======================================================================
ERROR: pvlib.test.test_pvsystem.test_calcparams_desoto
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/holmgren/git_repos/pvlib-python/pvlib/test/test_pvsystem.py", line 206, in test_calcparams_desoto
    assert_series_equal(np.round(IL, 3), pd.Series([0.0, 6.036], index=times))
  File "/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/numpy/core/fromnumeric.py", line 2786, in round_
    return round(decimals, out)
TypeError: round() takes from 1 to 2 positional arguments but 3 were given

======================================================================
ERROR: pvlib.test.test_pvsystem.test_PVSystem_calcparams_desoto
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/holmgren/git_repos/pvlib-python/pvlib/test/test_pvsystem.py", line 226, in test_PVSystem_calcparams_desoto
    assert_series_equal(np.round(IL, 3), pd.Series([0.0, 6.036], index=times))
  File "/Users/holmgren/miniconda3/envs/pvlib35/lib/python3.5/site-packages/numpy/core/fromnumeric.py", line 2786, in round_
    return round(decimals, out)
TypeError: round() takes from 1 to 2 positional arguments but 3 were given

----------------------------------------------------------------------
Ran 232 tests in 72.728s

FAILED (SKIP=2, errors=2)
@wholmgren wholmgren added this to the 0.3 milestone Mar 12, 2016
@wholmgren
Copy link
Member Author

Also, this why my recent PRs #128 #129 are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant