Skip to content

Create new temperature model(s) incorporating a simple radiative loss term. #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adriesse opened this issue Nov 17, 2022 · 12 comments
Closed
Milestone

Comments

@adriesse
Copy link
Member

adriesse commented Nov 17, 2022

Is your feature request related to a problem? Please describe.
The most frequently used operating temperature models do not account properly for radiative losses to the sky.

Describe the solution you'd like
Create enhanced versions of the existing models (at least one) incorporating a simple but effective radiative loss term as described in: Driesse, A. et al (2022) "Improving Common PV Module Temperature Models by Incorporating Radiative Losses to the Sky". SAND2022-11604. 10.2172/1884890

Describe alternatives you've considered
Watching TV.

@mikofski
Copy link
Member

@adriesse what kind of TV you been watching?

@cwhanse
Copy link
Member

cwhanse commented Nov 17, 2022

The point in the technical report is that temperature models fit measurements better when a radiative loss term is included. Is that correct?

The generic coefficients for e.g. Faiman, SAPM would not be the right values to use in a model including radiative loss terms, I think. Is there enough data at hand to come up with default coefficients for the new temperature model, or to convert from the generic coefficients?

@adriesse
Copy link
Member Author

The point in the technical report is that temperature models fit measurements better when a radiative loss term is included. Is that correct?

Yes.

The generic coefficients for e.g. Faiman, SAPM would not be the right values to use in a model including radiative loss terms, I think. Is there enough data at hand to come up with default coefficients for the new temperature model, or to convert from the generic coefficients?

You're quite right, those would need to be changed to something (smaller). I'm working on a data set and demo as well, and will reflect on what values to suggest. In general I must say that I am trending toward having fewer default values filled in to encourage users to think more about what they're doing. This might be a situation where no defaults would be appropriate in the function, but with sample values in the Notes.

@adriesse
Copy link
Member Author

@adriesse what kind of TV you been watching?

As long as this issue is moving forward: None!

@kandersolar
Copy link
Member

An idea, perhaps a bad one: as an alternative to creating *_rad variants of existing models, is it possible and practical to implement the radiative loss term as a standalone generic secondary function kind of like temperature.prilliman?

@adriesse
Copy link
Member Author

Not a bad thought. I did actually consider some other approaches, like preprocessing/reducing poa_global or using a factory function to make the rad models on demand. Or something cool with a class again. But I didn't actually try them out.

For parameter fitting it's certainly much easier to have a new function like this one, and I don't think I'll do more than one in the near future anyway.

@adriesse
Copy link
Member Author

The generic coefficients for e.g. Faiman, SAPM would not be the right values to use in a model including radiative loss terms, I think. Is there enough data at hand to come up with default coefficients for the new temperature model, or to convert from the generic coefficients?

You're quite right, those would need to be changed to something (smaller). I'm working on a data set and demo as well, and will reflect on what values to suggest. In general I must say that I am trending toward having fewer default values filled in to encourage users to think more about what they're doing. This might be a situation where no defaults would be appropriate in the function, but with sample values in the Notes.

The default behaviour with ir_down==None is now same as Faiman, so those u0/u1 default values might still be appropriate.

@cwhanse
Copy link
Member

cwhanse commented Nov 21, 2022

I like the design @adriesse

@adriesse
Copy link
Member Author

adriesse commented Nov 21, 2022

Thanks! I could potentially rename the parameters, e.g. u0r and u1r.

@cwhanse
Copy link
Member

cwhanse commented Nov 21, 2022

I think it's better with the same names as faiman. I'm on the fence whether this is an extension of faiman and could be added into that existing function, or, kept separate as a separate model. I can see benefits either way.

@kandersolar kandersolar added this to the 0.9.4 milestone Dec 1, 2022
@kandersolar kandersolar mentioned this issue Dec 9, 2022
9 tasks
@kandersolar
Copy link
Member

@adriesse should we close this now that #1595 is merged, or do you plan to add additional augmented model implementations someday?

@adriesse
Copy link
Member Author

We can open another issue if/when the demand for additional models becomes overwhelming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants