Skip to content

Group/organize model functions and corresponding parameter fitting functions #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adriesse opened this issue Dec 21, 2022 · 2 comments

Comments

@adriesse
Copy link
Member

adriesse commented Dec 21, 2022

One thing that is not clear is where various existing and future fitting functions should go. In general I think the best place for them would be as close as possible to the models they serve, both in the code (except if they are really long) and in the API reference. There could be a section listing just fitting functions as there is now, but I would see that as secondary.

Originally posted by @adriesse in #1598 (comment)

Let's take up @adriesse's point about where functions should live and be listed in a separate issue (Anton, can you open one?).

Originally posted by @kanderso-nrel in #1598 (comment)

@adriesse adriesse changed the title Develop standard approach for grouping model function and corresponding parameter fitting functions Group/organize model functions and corresponding parameter fitting functions Dec 21, 2022
@cwhanse
Copy link
Member

cwhanse commented Dec 21, 2022

Is this an issue with organizing the documents, the code, or both?

@adriesse
Copy link
Member Author

It's worth considering the question for both. Perhaps more of a discussion item than an issue now, but eventually it could lead to some code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants