Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary file left from removed functions *_ecmwf_macc #2275

Closed
echedey-ls opened this issue Oct 22, 2024 · 0 comments · Fixed by #2276
Closed

Unnecessary file left from removed functions *_ecmwf_macc #2275

echedey-ls opened this issue Oct 22, 2024 · 0 comments · Fixed by #2276
Labels
testing
Milestone
v0.11.2

Comments

@echedey-ls
Copy link
Contributor

Describe the bug
A file not used in the repository for any purpose has been found while working on #1056.
This file is pvlib/data/aod550_tcwv_20121101_test.nc

From the git blame, I think it got forgotten from the removal of get_ecmwf_macc and read_ecmwf_macc :

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to find any reference to this file through the repo.
  2. Nothing found.

Expected behavior
To be used for anything, or at least be documented.

Screenshots
N/A

Versions:

  • pvlib.__version__: v0.11.1

Additional context
See issue and PR linked above.
@echedey-ls echedey-ls changed the title [MAINT]: cleanup unnecessary file left from removed functions *_ecmwf_macc Unnecessary file left from removed functions *_ecmwf_macc Oct 22, 2024
@echedey-ls echedey-ls mentioned this issue Oct 22, 2024
Merged
4 tasks
@kandersolar kandersolar added this to the v0.11.2 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging a pull request may close this issue.

[MAINT]: Delete aod550_tcwv_20121101_test.nc echedey-ls/pvlib-python
2 participants
@kandersolar @echedey-ls