-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use pandas wrapper functions for the test suite #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tests pass. Codecov is low because it's only getting results from one branch of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for a what's new entry. It might be worth testing the _check_pandas_assert_kwargs
function with a mocked pd.__version__
.
A mocked version test is interesting but I'm not sure how it would work. Mock the other version and test that it raises a TypeError for the unexpected keyword argument? |
I'd patch and set the appropriate return_value for both conditions regardless of the true pandas version. The test would assert that the correct kwargs are included/excluded from the function. |
Thanks, that got me on the right track. I've added a test, but wouldn't be surprised if it could be made simpler. |
thanks @kanderso-nrel! |
Tests addedUpdates entries todocs/sphinx/source/api.rst
for API changes.Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.Seeing what Azure thinks of the changes.
Possible to-do items: