-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Expose temperature.fuentes in PVSystem and ModelChain #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c3b794b
add methods, some tests
kandersolar 484bab7
some more tests
kandersolar 16f4579
api.rst and whatsnew
kandersolar 70ce880
add surface_tilt override, note, and test
kandersolar 301967a
Update pvlib/pvsystem.py
kandersolar 512df4c
reflow docstring text for 80 char limit
kandersolar e93d316
Merge branch 'master' into fuentes_api
kandersolar 8a5fb6a
Merge branch 'master' into fuentes_api
kandersolar 7bdf256
Update docs/sphinx/source/whatsnew/v0.8.1.rst
kandersolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
'surface_tilt'
is aPVSystem
attribute, not to be found intemperature_model_parameters
We might also consider getting
'module_width'
and'module_length'
frommodule_parameters
, although: the database doesn't supply these values and they aren't used anywhere else.'module_height'
is really an attribute of the PV System.For now, I'm OK expecting the
'module_'
values intemperature_model_parameters
but they will move once another, non-temperature function needs this information - e.g., a bifacial irradiance function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid points. I unthinkingly pulled all the extra parameters from
temperature.fuentes
and dumped them there.I can imagine some people objecting to using Fuentes with the real
surface_tilt
value because they want the same behavior as the SSC implementation of PVWatts, which hardcodes the tilt at 30. Would it make sense to use thePVSystem
attributes by default but allow the user to override them by providing alternate values in thetemperature_model_parameters
dictionary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a better idea at the moment, than using
temperature_model_parameters['surface_tilt']
as the signal to override. But I think it risks confusing users, to have two 'surface_tilt' quantities with different meanings. Maybe a Note in thePVSystem.celltemp_fuentes
docstring and move ahead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also something to consider when creating an Array class.