Skip to content

Handle aoi>90 correctly in spectrum.spectrl2 #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

kandersolar
Copy link
Member

Basically just copying over the two checks in haydavies.

@kandersolar kandersolar added the bug label Dec 4, 2021
@kandersolar kandersolar added this to the 0.9.1 milestone Dec 4, 2021
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worthwhile to add a similar note to irradiance.haydavies? Something like "When supplying projection_ratio, consider constraining its values when zenith angle approaches 90 degrees. See code for details." Certainly not required here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spectrum.spectrl2 calculates negative irradiance for angle of incidence outside +/- 90°
3 participants