Move rtd advertisement to footer #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
approved these changes
Dec 17, 2021
kandersolar
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
Thanks @AdamRJensen! Here are a few comments in case anyone is curious (like I was) what the default values are for these settings.
| @@ -158,6 +158,7 @@ | |||
| ], | |||
| "use_edit_page_button": True, | |||
| "show_toc_level": 1, | |||
| "footer_items": ["copyright", "sphinx-version", "sidebar-ethical-ads"], | |||
There was a problem hiding this comment.
default: "footer_items": ["copyright", "sphinx-version"]
https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/sections.html#the-footer
kandersolar
reviewed
Dec 27, 2021
| @@ -198,7 +199,9 @@ | |||
| #html_use_smartypants = True | |||
|
|
|||
| # Custom sidebar templates, maps document names to template names. | |||
| #html_sidebars = {} | |||
| html_sidebars = { | |||
| "**": ["search-field", "sidebar-nav-bs"] # "sidebar-ethical-ads" | |||
There was a problem hiding this comment.
default: "**": ["search-field", "sidebar-nav-bs", "sidebar-ethical-ads"]
https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/sections.html#the-left-sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Tests added- [ ] Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).- [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.