Skip to content

Remove v0.9.0 deprecations #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 23, 2023
Merged

Remove v0.9.0 deprecations #1771

merged 8 commits into from
Jun 23, 2023

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jun 13, 2023 •
edited
Loading

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR removes things deprecated in v0.9.0 and marked for removal in v0.10.0:

  • SingleAxisTracker
  • the "pass-through" attributes for PVSystem and ModelChain
  • the celltemp and inverter PVSystem methods replaced by get_ wrappers
  • eta_m in temperature.pvsyst_cell

@kandersolar kandersolar added this to the 0.10.0 milestone Jun 13, 2023
@kandersolar kandersolar mentioned this pull request Jun 13, 2023
Closed
@kandersolar kandersolar marked this pull request as ready for review June 16, 2023 18:17
@kandersolar kandersolar requested a review from AdamRJensen June 16, 2023 18:18
@kandersolar kandersolar mentioned this pull request Jun 18, 2023
Closed
AdamRJensen
AdamRJensen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If there is anything specific that needs a more detailed review lmk.

@kandersolar
Copy link
Member Author

kandersolar commented Jun 23, 2023 •
edited
Loading

I just looked through these changes again, and reviewed the docs build logs, and things seem ok to me too. Merging...

@kandersolar kandersolar merged commit 6606af7 into pvlib:main Jun 23, 2023
@kandersolar kandersolar deleted the remove_090_deprecations branch June 23, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamRJensen AdamRJensen AdamRJensen approved these changes

Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kandersolar @AdamRJensen