-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docstring params #1790
Closed
Closed
Commits on Jun 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8964a8c - Browse repository at this point
Copy the full SHA 8964a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10812fb - Browse repository at this point
Copy the full SHA 10812fbView commit details -
^(\s{8}|\s{4})(?!try|else|doi|DOI|Warning|Access|Requests|Note)(\w*): (?!.*=|.*:)(.+)$ This matches strings in test_pvsystem.py wrongly
Configuration menu - View commit details
-
Copy full SHA for 281dc67 - Browse repository at this point
Copy the full SHA 281dc67View commit details -
Deleting negative lookahead |.*: ^(\s{8}|\s{4})(?!try|else|doi|DOI|Warning|Access|Requests|Note)(\w*): (?!.*=)(.+)$ Reason: too many `default: ` strings
Configuration menu - View commit details
-
Copy full SHA for f2a92b6 - Browse repository at this point
Copy the full SHA f2a92b6View commit details -
Exclude .*=| from negative lookahead ^(\s{8}|\s{4})(?!try|else|doi|DOI|Warning|Access|Requests|Note)(\w*): (?!.*:)(.+)$ Reason: just this line 🌝 Remaining matches are type annotations in modelchain.py and pvsystem.py
Configuration menu - View commit details
-
Copy full SHA for 35fd3e7 - Browse repository at this point
Copy the full SHA 35fd3e7View commit details
Commits on Jun 28, 2023
-
Change excessive parentheses from default syntax in parameters
Regex: (?<spaces>\s{8}|\s{4})(?<name>\w*) : (?<type>.*) \(optional, default=(?<default>.*)\)$ Subs pattern: $1$2 : $3, default $4 Including: pvlib/**/*.py Excluding: docs No more "(optional, " found in .py files
Configuration menu - View commit details
-
Copy full SHA for d72a654 - Browse repository at this point
Copy the full SHA d72a654View commit details -
Configuration menu - View commit details
-
Copy full SHA for debcc63 - Browse repository at this point
Copy the full SHA debcc63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3497ff4 - Browse repository at this point
Copy the full SHA 3497ff4View commit details -
default None -> optional (pvlib#1574)
(?<spaces> {8}| {4})(?<name>\w*) : (?<types>.*), default None$ $1$2 : $3, optional (?<spaces> {8}| {4})(?<name>\w*) : None or (?<type>.*), optional$ $1$2 : $3, optional (?<spaces> {8}| {4})(?<name>\w*) : (?<type>.*) or [nN]one, optional$ $1$2 : $3, optional Over files: pvlib/**/*.py
Configuration menu - View commit details
-
Copy full SHA for 6500add - Browse repository at this point
Copy the full SHA 6500addView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdd022c - Browse repository at this point
Copy the full SHA cdd022cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 016206c - Browse repository at this point
Copy the full SHA 016206cView commit details -
Merge branch 'refactor-docstring-params' of https://github.com/echede…
…y-ls/pvlib-python into refactor-docstring-params
Configuration menu - View commit details
-
Copy full SHA for db36922 - Browse repository at this point
Copy the full SHA db36922View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.