Allow asymmetrical rotation limits in pvlib.tracking.singleaxis
#1809
Conversation
single values
MichalArieli
changed the title
MichalArieli
changed the title
|
@MichalArieli I have no idea why GH is saying there are conflicts. Can you merge the current main from pvlib and push again? |
…add_min_angle_singleaxis_tracking
@cwhanse I did it. I think the conflict is still there. I'll try to solve it tomorrow (probably I'll just fork again and apply my changes). Thank you! |
There was a problem hiding this comment.
@MichalArieli please add a comment to docs/sphinx/source/whatsnew/v0.10.2.rst, and yourself to the list of contributors.
Thanks again for the contribution.
| rotation angle, and the minimum rotation angle is assumed to be the | ||
| opposite of the maximum angle. If a tuple of (min_angle, max_angle) | ||
| is provided, it represents both the minimum and maximum rotation angles. | ||
|
|
There was a problem hiding this comment.
I feel like we need to explain the orientation that distinguishes min_angle from max_angle. Suggest adding a new paragraph like:
A rotation to 'max_angle' is a counter-clockwise rotation about the y-axis of the tracker coordinate system. For example, for a tracker with 'axis_azimuth' oriented to the south, a rotation to 'max_angle' is towards the west, and a rotation toward 'min_angle' is in the opposite direction, toward the east.
There was a problem hiding this comment.
Thank you for this input! As you suggested, I have added this paragraph.
There was a problem hiding this comment.
Thanks @MichalArieli, this looks great! A couple nitpicks below.
One other thing: our automated linter is currently broken (#1722) so there's unfortunately no CI check for this currently, but could you re-wrap lines in .py files to 80 chars max?
|
|
||
| # Determine minimum and maximum rotation angles for the tracker based on max_angle. | ||
| # If max_angle is a single value, assume min_angle is the negative of max_angle. | ||
| if np.array(max_angle).size == 1: |
There was a problem hiding this comment.
| if np.array(max_angle).size == 1: | |
| if np.isscalar(max_angle): |
Maybe a bit easier to read while achieving the same thing?
| * Added support for asymmetric limiting angles in :py:func:`pvlib.tracking.singleaxis`, by modifying | ||
| the `min_angle` parameter to accept tuples. | ||
| (:pull:`1809`) |
There was a problem hiding this comment.
| * Added support for asymmetric limiting angles in :py:func:`pvlib.tracking.singleaxis`, by modifying | |
| the `min_angle` parameter to accept tuples. | |
| (:pull:`1809`) | |
| * Added support for asymmetric limiting angles in :py:func:`pvlib.tracking.singleaxis` and | |
| :py:class:`pvlib.pvsystem.SingleAxisTrackerMount` by modifying the ``max_angle`` | |
| parameter to accept tuples. (:issue:`1777`, :pull:`1809`) |
|
The title of this PR is quite interesting... |
kandersolar
changed the title
pvlib.tracking.singleaxis
|
Superseded by #1852. Thanks again @MichalArieli! |
min_angleargument totracking.singleaxis#1777docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Modify max_angle to accept tuples in addition to single values
(issue #1777)
In
tracking.singleaxisthe minimum angle of the tracker is always the opposite of the maximum angle. However, there are cases where the minimum angle can differ. (While NREL SAM does not support this feature, PVsyst does).To address this limitation and support non-symmetrical limiting angles, I have made a modification to the
min_angleparameter intracking.singleaxis. It now accepts tuples of the form (min_angle,max_angle). To maintain compatibility with the more common symmetrical limits, the parameter still allows a single value.Please review the changes. Thank you!