Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adopt ghi_clear variable name for clearsky GHI #2273

Closed
wants to merge 24 commits into from
Closed

[WIP] Adopt ghi_clear variable name for clearsky GHI #2273

wants to merge 24 commits into from

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Oct 21, 2024 •
edited
Loading

  • Partially closes Standardise variable name for clearsky GHI and DNI, add to glossary #2272
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Also related: #1253

@RDaxini RDaxini mentioned this pull request Oct 21, 2024
Open
@AdamRJensen AdamRJensen mentioned this pull request Oct 22, 2024
Merged
8 tasks
@RDaxini RDaxini changed the title Adopt ghi_clear variable name for clearsky GHI [WIP] Adopt ghi_clear variable name for clearsky GHI Oct 22, 2024
RDaxini and others added 20 commits October 25, 2024 14:30
@RDaxini
modify tests
b21e1eb
@RDaxini
add deprecation warning
57288e7
@RDaxini
Update clearsky.py
00d7b70
@RDaxini
Merge remote-tracking branch 'upstream/main' into ghi_clear
6c78cb8
@RDaxini
fix unrelated linting issues
5b273df
@RDaxini
fix unrelated linting issue
38a409d
@RDaxini
Update test_clearsky.py
263ad4e
@RDaxini
Revert "Update test_clearsky.py"
ba5ffaa 
This reverts commit 263ad4e.
@RDaxini
Reapply "Update test_clearsky.py"
f45cf19 
This reverts commit ba5ffaa.
@RDaxini
Revert "Update test_clearsky.py"
d7a6f83 
This reverts commit 263ad4e.
@RDaxini
Revert "fix unrelated linting issue"
fbd49e9 
This reverts commit 38a409d.
@RDaxini
Revert "fix unrelated linting issues"
84987b0 
This reverts commit 5b273df.
@RDaxini
Revert "Merge remote-tracking branch 'upstream/main' into ghi_clear"
1622571 
This reverts commit 6c78cb8, reversing
changes made to 00d7b70.
@RDaxini
Revert "Update clearsky.py"
5879282 
This reverts commit 00d7b70.
@RDaxini
Revert "add deprecation warning"
bbe9d4f 
This reverts commit 57288e7.
@RDaxini
Revert "modify tests"
aeab5cc 
This reverts commit b21e1eb.
@RDaxini
Revert "irradiance.py: dirindex()"
9be20a6 
This reverts commit 00ffbd9.
@RDaxini
Revert "clearsky.py: detect_clearsky"
efdbbd8 
This reverts commit 9fa9fdc.
@RDaxini
Revert "clearsky.py: haurwitz(), detect_clearsky"
feab85c 
This reverts commit 37d17b8.
@RDaxini
Revert "irradiance.py: ghi_from_poa() and clearsky_index()"
c9c6900 
This reverts commit bf1c0d8.
@RDaxini RDaxini closed this Nov 25, 2024
@RDaxini RDaxini deleted the ghi_clear branch November 25, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise variable name for clearsky GHI and DNI, add to glossary
1 participant
@RDaxini