Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pytz with standard library's zoneinfo #2343

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

markcampanelli
Copy link
Contributor

This is a demonstration of how we could remove the direct dependency on pytz and adopt the IANA-compliant standard-library solution zoneinfo, available since Python 3.9. This also leads to a single-source-of-truth simplification of the timezone tracking in pvlib.location.Location. Note that pandas apparently still uses pytz extensively, but I did not find this to conflict.

TODO:
[ ] Update the extensive timezone tutorial in timetimezones.rst.

  • Closes Replace pytz with standard library's zoneinfo #2342
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pytz with standard library's zoneinfo
2 participants